Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "no value" to expression #1048

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

maiko3tattun
Copy link
Contributor

@maiko3tattun maiko3tattun commented Feb 24, 2024

In implementing track expression and phonemizer expression in the future, we need to clearly distinguish whether a phoneme has a value or not.

Changes:

  • To distinguish between "set value to 100" and "no value (default value of 100)", SetNote/PhonemeExpressionCommand will accept null as well as float.
  • In the expression panel and properties panel, the presence or absence of a value can be visually determined.
    image
  • Implement logic for "phonemizerExpressions".

What I want to implement in the future:

The ability for the phonemizer to recommend an expression(voicecolor, P flag, etc.) and for the user to override it.

bandicam.2024-02-24.22-34-29-283.mp4

(prototype)

@stakira
Copy link
Owner

stakira commented Feb 25, 2024

Cool stuff!

@stakira stakira merged commit 01baa35 into stakira:master Feb 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants